adding clang-tidy as a linter tool #2269
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| sudo apt-get install -y clang-tidy | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| - job: | ||
| name: ceph-pr-clang-tidy | ||
| node: small | ||
| project-type: freestyle | ||
| defaults: global | ||
| display-name: 'ceph: Clang-tidy checks' | ||
| concurrent: true | ||
| quiet-period: 5 | ||
| block-downstream: false | ||
| block-upstream: false | ||
| retry-count: 3 | ||
| properties: | ||
| - build-discarder: | ||
| days-to-keep: 15 | ||
| artifact-days-to-keep: 15 | ||
| - github: | ||
| url: https://github.com/ceph/ceph/ | ||
|
|
||
| parameters: | ||
| - string: | ||
| name: ghprbPullId | ||
|
||
| description: "the GitHub pull id, like '72' in 'ceph/pull/72'" | ||
| default: origin/main | ||
|
|
||
| scm: | ||
| - git: | ||
| url: https://github.com/ceph/ceph.git | ||
| name: origin | ||
| branches: | ||
| - origin/pr/${ghprbPullId}/merge | ||
| refspec: +refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/* | ||
| skip-tag: true | ||
| shallow-clone: true | ||
| honor-refspec: true | ||
| timeout: 20 | ||
|
|
||
| triggers: | ||
| - github-pull-request: | ||
| allow-whitelist-orgs-as-admins: true | ||
| org-list: | ||
| - ceph | ||
| trigger-phrase: 'jenkins test clang-tidy' | ||
| only-trigger-phrase: false | ||
| github-hooks: true | ||
| permit-all: true | ||
| auto-close-on-fail: false | ||
| status-context: "Signed-off-by" | ||
| started-status: "checking if bugs exist in file" | ||
| success-status: "no bugs found" | ||
| failure-status: "bugs found" | ||
|
|
||
| builders: | ||
| - shell: | ||
| !include-raw: | ||
| - ../../../scripts/build_utils.sh | ||
| - ../../build/build | ||
|
|
||
| publishers: | ||
| - junit: | ||
| results: report.xml | ||
| allow-empty-results: true | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course this only works if the build machine is an apt-based system, which it may not be using your current node labels. It might be more appropriate to install the package inside the pbuilder image in that case, too, although it probably doesn't matter too much; there are ways of adding extra packages to the pbuilder image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need an answer for this; does clang-tidy exist for RHEL-like systems? or do we want to restrict this job to only apt systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is available but for now lets keep the job to apt systems only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this accomplished? won't the command be executed (and fail) on all systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job specifies the labels for the jenkins builder it wants; we'll need to add something like 'jammy' as a label, that should suffice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should I add this 'jammy' label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job.node is the list of labels the builder must satisfy. You probably want jammy && small
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmick I have added
node: jammy && small