Skip to content

Conversation

@djgalloway
Copy link
Contributor

No description provided.

@djgalloway
Copy link
Contributor Author

@djgalloway djgalloway requested a review from dmick September 25, 2025 14:31
@zmc
Copy link
Member

zmc commented Sep 25, 2025

6330 triggered three ceph-dev-pipeline builds, all default flavor and centos9 - I don't see rocky there

@djgalloway
Copy link
Contributor Author

6330 triggered three ceph-dev-pipeline builds, all default flavor and centos9 - I don't see rocky there

Rocky was missing because I went back and was pushing this job config to ceph-dev-cron manually before adding rocky10. Oversight on my part.

The crimson flavors were missing because I was sending FLAVOR= not FLAVORS=. Thanks for catching that.

Fixed both. Testing here: https://jenkins.ceph.com/job/ceph-dev-cron/6331/

@zmc
Copy link
Member

zmc commented Sep 25, 2025

Thanks! And do you think we could also populate the build description with metadata about the triggered builds, similar to ceph-trigger-build? As it stands now it's not possible to discover what was triggered from this job.

@djgalloway
Copy link
Contributor Author

djgalloway commented Sep 25, 2025

Screenshot 2025-09-25 at 4 07 28 PM

I don't think it's possible to set the build description to show what distro/flavors got triggered because the same job triggers multiple pipeline jobs based on if there are new commits in $BRANCH compared to the last cron entry.

So, for example, at the end of a single ceph-dev-cron job, we could have triggered reef, tentacle, and main and all of those have different flavor/distro matrices. So the build description would just get set to the last conditional step's DISTROS.

@zmc
Copy link
Member

zmc commented Sep 25, 2025

I guess that's a limitation of the freestyle job type. Maybe in the future we could add a cron trigger to ceph-trigger-build an obsolete this job, since the logic already exists there.

@djgalloway
Copy link
Contributor Author

Oh, and now that I think of it, SHA1 and BRANCH will not be correct either if multiple release branches got built. Don’t merge this. Let me see how difficult it might be to just move the cron logic over to ceph-trigger-build.

@dmick
Copy link
Member

dmick commented Sep 25, 2025

for the "set to the last one"....could we set it with an append, like "DESC=DESC + "? That might also be a really cheap progress indicator

@zmc
Copy link
Member

zmc commented Oct 9, 2025

What's the status on this PR?

@djgalloway
Copy link
Contributor Author

What's the status on this PR?

I started another branch so that:

  1. Only branches that changed would get triggered
  2. ceph-dev-cron is using groovy
  3. We would notify shaman that a build was triggered sooner BUT:
    a. All of DISTRO, DISTRO_VERSION, BRANCH, SHA1, FLAVOR have to be sent for submit and update build status in order for the same entry in Shaman's DB to get updated.
    b. I intended to start ripping this logic back out and then split cron-pipeline2 back out into logical commits but got pulled back into lab migration stuff

cron-pipeline2 should take precedence over this branch but needs:

  1. The shaman notification logic ripped back out
  2. Logical commit structure

It's on my to-do list still. I also would not be offended if someone hijacked the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants