ceph-dev-pipeline: check shaman for "are there binaries" #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
2 times, most recently
from
01b546d to
f2341ae
Compare
Checking chacra isn't the right check, since this build's chacra url is not necessarily the prior successful build's chacra url (there are multiple chacra instances). Instead, check shaman to see if there is a built repo; if so, the build can be skipped. build_container will search shaman again to find the repo url to use to build the container, if necessary. Signed-off-by: Dan Mick <[email protected]>
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
from
f2341ae to
aed8cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking chacra isn't the right check, since this build's chacra url is not necessarily the prior successful build's chacra url (there are multiple chacra instances). Instead, check shaman to see if there is a built repo; if so, the build can be skipped. build_container will search shaman again to find the repo url to use to build the container, if necessary.
(so far completely untested; put up here for discussion)