Change the Twitter old logo to new X logo #815
Conversation
|
Can one of the admins verify this patch? |
|
Is this required? Meaning, are we under any legal obligation to change the logo/name? |
@djgalloway Thank you for reviewing the PR. While there may not be a strict legal obligation, updating the logo ensures that the Ceph website reflects the latest branding and maintains accuracy in external references. Since Twitter has officially rebranded to X, keeping outdated logos may cause inconsistency in our UI. This is a minor but relevant update to enhance the website’s visual correctness. Let me know if any further modifications are needed. I appreciate your time and consideration. |
|
Hello @ljflores and @djgalloway, I appreciate your time reviewing this PR. Please let me know if any modifications are needed to move forward with the merge. Looking forward to your feedback. Thank you |
Thingee
left a comment
Thingee
left a comment
There was a problem hiding this comment.
This looks good to me, but I'm not sure why we need to update a single blog post. There are other instance of 'twitter' that are found in src/news/blog.
|
Hello @Thingee, @ljflores, and @djgalloway, Thank you for your valuable feedback. I have now updated all remaining instances of the old Twitter logo and name within src/news/blog to ensure consistency across the repository. Please let me know if any further modifications are needed. I appreciate your time and review. Thank you. |
|
Hello @Thingee, @ljflores, and @djgalloway, Thank you for your time and feedback on this PR. Since the updates have been made and the changes were approved, could you please review the latest updates and let me know if anything else is required before merging? |
|
@Thingee, @ljflores, and @djgalloway, I have addressed the missing file warnings and improved error handling in the Eleventy configuration to enhance build stability. These updates will help ensure a smoother and more reliable build process. You can review the chages: Thank you |
Thanks for adding this enhancement to the Eleventy configuration. Can you please move it to a separate PR? |
|
Dear @Thingee, @ljflores, and @djgalloway, I have separated the PRs as per your suggestion. The updates related to the Twitter logo change and the Eleventy configuration improvements are now in separate PRs for better clarity and reviewability. You can find the updated PR here: PR #847. Kindly review the changes at your convenience and let me know if any further modifications are required. I appreciate your time and feedback. Looking forward to your response. |
| @@ -1,87 +1,112 @@ | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
There was a problem hiding this comment.
Again, this change has nothing to do with updating the twitter logo.
5 participants
I will change the Twitter old logo and adding a new X logo
Fixes: #717