-
Notifications
You must be signed in to change notification settings - Fork 6.2k
cmake: Introduce ctest labels for testing #29844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
epuertat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Just a few suggestions/questions left over there.
|
i'd recommend s/build:/cmake:/ in the title of your commit message. we could be more specific here. |
59f9a1c to
e9e5f6f
Compare
epuertat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is improving even further! Thanks @wjwithagen! Just a few suggestions: mostly related to the hardcoded values and perhaps explaining this in Ceph Developer's docs.
|
BTW, with the help of @alfredodeza we've created a Jenkins Build Analyzer parser for CTest Failures, so the output in case of failure (like the above "make check fail") would look like the following:
|
|
You can supress the total label runtime if wanted with |
bb5b582 to
46e677f
Compare
epuertat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just added a minor suggestion to improve the docs already provided. Thanks a lot for this @wjwithagen !
46e677f to
f125dcc
Compare
a854a58 to
169d9f6
Compare
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Keep away from this, bad stale bot! I think this is valuable in order to speed-up/fine-tune CI. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
@wjwithagen - i am unsure if you are still working on ceph BUT was hoping/wondering if we can/should revive this PR. We are trying to improve the general builds, tests - developer experience around this and I think would really help with that endeavor |
|
Recovering this PR in the context of CI improvements, as this would enable both:
|
@cbodley is trying out an approach to do this based on parsing |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
cmake: Introduce ctest TEST labels for testing and COST
Tests in CMake/Ctest can have labels on which can be filtered
Which allows to run certain subsets of by using RE filters
in ctest.
COST will determine the order in which the tests are executed.
Current settings will start with long running tests.
Like:
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docs