nuke_bucket: Abort multipart uploads before bucket deletion #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nuke_bucket cleanup function was failing to delete buckets that had ongoing multipart uploads because it only deleted objects but didn't abort the uploads. This caused test teardown to fail with BucketNotEmpty errors when tests left multipart uploads incomplete. Add logic to list and abort all multipart uploads in a bucket before attempting to delete it. This ensures clean test teardown even when tests fail or don't complete their uploads. This change is necessary for S3 implementations that correctly enforce the requirement that buckets with ongoing multipart uploads cannot be deleted, while still supporting deferred cleanup of part data (where AbortMultipartUpload removes metadata immediately but storage cleanup happens asynchronously). Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nuke_bucket cleanup function was failing to delete buckets that had ongoing multipart uploads because it only deleted objects but didn't abort the uploads. This caused test teardown to fail with BucketNotEmpty errors when tests left multipart uploads incomplete.
Add logic to list and abort all multipart uploads in a bucket before attempting to delete it. This ensures clean test teardown even when tests fail or don't complete their uploads.
This change is necessary for S3 implementations that correctly enforce the requirement that buckets with ongoing multipart uploads cannot be deleted, while still supporting deferred cleanup of part data (where AbortMultipartUpload removes metadata immediately but storage cleanup happens asynchronously).