Skip to content

D3D12 colour RT transitions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

D3D12 colour RT transitions #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tinydx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4543,6 +4543,9 @@ void tr_internal_dx_cmd_image_transition(tr_cmd* p_cmd, tr_texture* p_texture, t
void tr_internal_dx_cmd_render_target_transition(tr_cmd* p_cmd, tr_render_target* p_render_target, tr_texture_usage old_usage, tr_texture_usage new_usage)
{
assert(NULL != p_cmd->dx_cmd_list);

// FIXME: Need to find out, what was the intention behind this special handling?
bool transitioned_attachment_0 = false;

if (p_render_target->sample_count > tr_sample_count_1) {
if (1 == p_render_target->color_attachment_count) {
Expand All @@ -4553,10 +4556,12 @@ void tr_internal_dx_cmd_render_target_transition(tr_cmd* p_cmd, tr_render_target
if (tr_texture_usage_present == (ss_attachment->usage & tr_texture_usage_present)) {
if ((tr_texture_usage_present == old_usage) && (tr_texture_usage_color_attachment == new_usage)) {
tr_internal_dx_cmd_image_transition(p_cmd, ss_attachment, tr_texture_usage_present, tr_texture_usage_color_attachment);
transitioned_attachment_0 = true;
}

if ((tr_texture_usage_color_attachment == old_usage) && (tr_texture_usage_present == new_usage)) {
tr_internal_dx_cmd_image_transition(p_cmd, ss_attachment, tr_texture_usage_color_attachment, tr_texture_usage_present);
transitioned_attachment_0 = true;
}
}
}
Expand All @@ -4568,14 +4573,26 @@ void tr_internal_dx_cmd_render_target_transition(tr_cmd* p_cmd, tr_render_target
if (tr_texture_usage_present == (attachment->usage & tr_texture_usage_present)) {
if ((tr_texture_usage_present == old_usage) && (tr_texture_usage_color_attachment == new_usage)) {
tr_internal_dx_cmd_image_transition(p_cmd, attachment, tr_texture_usage_present, tr_texture_usage_color_attachment);
transitioned_attachment_0 = true;
}

if ((tr_texture_usage_color_attachment == old_usage) && (tr_texture_usage_present == new_usage)) {
tr_internal_dx_cmd_image_transition(p_cmd, attachment, tr_texture_usage_color_attachment, tr_texture_usage_present);
transitioned_attachment_0 = true;
}
}
}
}

// FIXME: Need to find out, what was the intention behind this special handling?
for (uint32_t i = 0; i < p_render_target->color_attachment_count; ++i) {
if (i == 0 && transitioned_attachment_0) {
continue;
}
tr_texture* attachment = p_render_target->color_attachments[0];
assert(0 == (attachment->usage & tr_texture_usage_present));
tr_internal_dx_cmd_image_transition(p_cmd, attachment, old_usage, new_usage);
}
}

void tr_internal_dx_cmd_depth_stencil_transition(tr_cmd* p_cmd, tr_render_target* p_render_target, tr_texture_usage old_usage, tr_texture_usage new_usage)
Expand Down