Inline the non-param nudge upper/lower bound routines #27980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking at some generated code that used lo..<hi ranges today, I was surprised to find a function call to compute the "hi-1" implied by "hi", which seems like overkill in the generated C code. This changes the non-param versions of the routine to be inlined which seems like it can only help, and likely not hurt, the compiler back-end. --- Signed-off-by: Brad Chamberlain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at some generated code that used lo..<hi ranges today, I was surprised to find a function call to compute the
hi-1implied by<hi, which seems like overkill in the generated C code. This changes the non-param versions of the routine to be inlined which seems like it can only help, and likely not hurt, the ability of the back-end compiler to optimize the code.