fix(wcwidth): measure wcwidth per codepoint - #933
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
+ Coverage 48.00% 53.59% +5.59%
==========================================
Files 181 55 -126
Lines 13129 3351 -9778
==========================================
- Hits 6302 1796 -4506
+ Misses 6433 1493 -4940
+ Partials 394 62 -332 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrinoff
force-pushed
the
fix/wcwidth
branch
3 times, most recently
from
August 11, 2026 14:27
0ef2e18 to
f6f7b2a
Compare
Signed-off-by: drew <me@andrinoff.com>
Signed-off-by: drew <me@andrinoff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
FirstGraphemeClustermeasures a cluster underWcWidthby handing it togo-runewidth'sStringWidth, which reports the width of the cluster's first non-zero-width rune. That is a grapheme measurement, not a wcwidth one. It now sums the cluster's codepointsWhy?
Fixes charmbracelet/bubbletea#1737
Fixes CHARM-1896
related charmbracelet/ultraviolet#150