Conversation
etimberg
approved these changes
Oct 2, 2026
kurkle
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
controller.polarArea/pointLabels/overlappingfixture fails on Ubuntu Firefox with a 293-pixel (0.11%) difference against its 0.1% tolerance. The same failure reproduces on pristine master and on the types-only #12321, with identical per-browser canvas output. This is the shared failure reported during #12321.Disable image smoothing in this fixture's existing
options.runcallback before redrawing its sprite text, and regenerate only its expected PNG from Ubuntu Chrome. This removes browser-dependent interpolation of the overlapping glyph sprites at fractional coordinates. Captured point-label coordinates, chart area, and scale radius remain identical within each browser, including all 50 visible labels and the same 35 overlapping label pairs. The comparison threshold and tolerance remain unchanged.Validation:
--auto-watch --single-run --coverage --grep; 1703/1703 passed in each of Chrome 154, Firefox 155, and Firefox 156, plus the isolated fixture comparison in each browser. Every test command is required to return zero for this diagnostic run to pass.git diff --checkpassed. Increasing point-label padding from 5 to 6 still fails the canonical image comparison (5.13% difference), verifying the fixture continues to detect layout changes.AI assistance: implementation, testing, and this description were prepared with OpenAI Codex.