refactor(executor): defer Command creation to when execute() called#44
Merged
Conversation
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 75.10% 75.21% +0.10%
==========================================
Files 105 105
Lines 10510 10556 +46
==========================================
+ Hits 7894 7940 +46
Misses 2616 2616 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares us for a subsequent refactoring of
create_commandin #41 . Deferring the creation ofCommandmeans we don't need to make a second call to check if an executable exists after refactoringcreate_command. This PR is a part separated from #41 and does not contain any functional changes.