-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Labels
Description
The code in src/axi2tlul/sub2tlul.sv contains this line:
assign tl_o.a_size = size[top_pkg::TL_SZW-1:0];and, as such, depends on top_pkg.
That package is part of lc_ctrl and contains a copy-paste of parameters from the caliptra_tlul_pkg package from caliptra-rtl.
As a result:
- The RTL code from axi2tlul depends on
lc_ctrl. - This dependency ties to a very generic name.
- The code that's pulled in is actually copy-pasted from
caliptra_tlul_pkgin a different repository (although that repository is already a dependency).
I propose that an engineer makes the following changes:
- Make the line in
sub2tlulusecaliptra_tlul_pkg::TL_SZW(and add a dependency tocompile.ymlif it isn't there already) - Think hard about the
top_pkgname in design RTL. This looks pretty mad to me, at least. - Either remove that package (and use the source instead) or, if keeping it, make it explicitly depend on
caliptra_tlul_pkgand avoid the copy-paste.