Skip to content

Missing dependency in axi2tlul #950

@rswarbrick

Description

@rswarbrick

The code in src/axi2tlul/sub2tlul.sv contains this line:

    assign tl_o.a_size      = size[top_pkg::TL_SZW-1:0];

and, as such, depends on top_pkg.

That package is part of lc_ctrl and contains a copy-paste of parameters from the caliptra_tlul_pkg package from caliptra-rtl.

As a result:

  • The RTL code from axi2tlul depends on lc_ctrl.
  • This dependency ties to a very generic name.
  • The code that's pulled in is actually copy-pasted from caliptra_tlul_pkg in a different repository (although that repository is already a dependency).

I propose that an engineer makes the following changes:

  • Make the line in sub2tlul use caliptra_tlul_pkg::TL_SZW (and add a dependency to compile.yml if it isn't there already)
  • Think hard about the top_pkg name in design RTL. This looks pretty mad to me, at least.
  • Either remove that package (and use the source instead) or, if keeping it, make it explicitly depend on caliptra_tlul_pkg and avoid the copy-paste.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions