Repository navigation
Conversation
The aarch64-pc-windows-gnullvm build linked libunwind dynamically, so sd.exe imported MSYS2's libunwind.dll and would not start on a machine without it. Build with +crt-static so libunwind is linked statically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Pushed a fix for the GNU-family build: the previous gnullvm artifact imported MSYS2's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toolchain
The GNU-family target installs the MSYS2 CLANGARM64 toolchain and uses the setup action output for Cargo linker configuration. This avoids a runner-specific hard-coded path.
The gnullvm build is linked with
-C target-feature=+crt-static. Without it, sd.exe imports MSYS2'slibunwind.dlland does not start on a machine without MSYS2. The existing x86_64-pc-windows-gnu build is unaffected; Rust links its unwinder statically.Validation
sd --versionwith only System32 on PATH.The fork-only validation workflow is not included in this PR.
Disclosure
This change was prepared with assistance from Claude (Anthropic) and OpenAI Codex. I reviewed the diff and validated it through the linked GitHub Actions runs.