Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file-based benchmark commands currently edit their inputs in place, so repeated runs no longer measure the same input. The regex example also lets the child shell expand
$1before sd sees it.Use
-pfor both sd commands and escape the capture references for hyperfine's child shell. Note the GNU sed/POSIX shell assumption, and remove the two old timing tables and speedup claims rather than imply they were measured with these corrected commands. The separate line-by-line/across results are unchanged.Related to #52. Validated command quoting with local shell stubs and checked preview behavior against the current source. No sd, hyperfine, project tests, or benchmarks were run. Prepared and reviewed with AI assistance.