Open
Conversation
Inter-operation is achieved with cgo. The wrapper offers an idiomatic
Go package for objective function minimization via L-BFGS.
Slight behavioral differences from the C library:
- The optimization routine is renamed to Minimize() (to not repeat the
package name).
- The optimization routine returns the final value of the objective
function. The C library allows ptr_fx to be NULL when the user does
not care about the value. In Go this is usually done by assigning _
to the return value, e.g.
_, err := lbfgs.Minimize(...)
My question is whether setting ptr_fx to NULL saves any call to
evaluate(). If that is true, then the design in Go has a
slightly higher cost when the user does not need the final
objective and we should revert to the C design.
- All errors returned from C lbfgs() is translated to Go errors
(except LBFGS_SUCCESS, in which case nil error is returned as is
idiomatic in Go).
Collaborator
|
This patch may need extra work if we land #23. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inter-operation is achieved with cgo. The wrapper offers an idiomatic
Go package for objective function minimization via L-BFGS.
Slight behavioral differences from the C library:
The optimization routine is renamed to Minimize() (to not repeat the
package name).
The optimization routine returns the final value of the objective
function. The C library allows ptr_fx to be NULL when the user does
not care about the value. In Go this is usually done by assigning _
to the return value, e.g.
My question is whether setting ptr_fx to NULL saves any call to
evaluate(). If that is true, then the design in Go has a
slightly higher cost when the user does not need the final
objective and we should revert to the C design.
All errors returned from C lbfgs() is translated to Go errors
(except LBFGS_SUCCESS, in which case nil error is returned as is
idiomatic in Go).