FileResourceLock#unlock_token nil root path and variable not defined #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm still trying to implement webdav in my app.
When testing lock and unlock with Office I had the following error:
TypeError: can't convert nil into Stringinfile_resource_lock.rb:80:in joinafter some research I found that
rootis not passed to#find_by_tokeninFileResource#unlockline:262.Long to find, easy to patch.
But then
#unlockas an undefined variabletok, I supposed it wasstruct.And finally, its need a little more investigation, but MS Word remove the first and last characters of the token when calling
unlockthen the store never find any token.I give a look at what is send to the webdav client and the token seem ok. I don't know enough about webdav and have no clue where to look, maybe Word misinterpret the xml sent or just want to be upsetting.
I made a monkey patch to find the good token.
MS Word generate a lot of lock request and fill the token table for the loaded file. Maybe the destroy action should clean all tokens for a given file.