Feature/unittest 2 #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviinfo173
commented
Apr 18, 2023
raviinfo173
commented
producer.py
Outdated
| self.cam.set(cv2.CAP_PROP_FPS, fps) | ||
| self.fps = fps | ||
|
|
Collaborator
There was a problem hiding this comment.
swhy we have some line formattings, seems you did a copy from annotatedVideoServer repo? can you please enhance them to be able to see actual changes
| from PIL import Image | ||
| from PIL import ImageDraw | ||
| from flask import Flask, Response | ||
| from tracklet.tailvisualization import draw_tail, midpoint_calculate, get_tracking_entry_with_midpoint, update_midpoint_to_tracklets |
Collaborator
There was a problem hiding this comment.
why we have this file? do we really need them for unittests. If I'm not mistaken that's a python2 feature
Collaborator
There was a problem hiding this comment.
We don't have to have those init empty files
Collaborator
|
@raviinfo173 pls take a look all the comments, and ping me once you need to discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.