Skip to content

Conversation

@kajkul
Copy link
Contributor

@kajkul kajkul commented Dec 17, 2025

Goal of this PR

Remove mubmle channel listeners when a client gets freed in order to prevent newly connected users form listening to channels that were left behind by the previous owner of that session id.

How is this PR achieving the goal

It adds new methods to the ChannelListener class that erase all the channels the user is listening to from both maps at once. I didn't use the exsiting API since that would mean holding the mutex per channel instead of once for the whole operation.

This PR applies to the following area(s)

Server

Successfully tested on

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Requires changes before it's considered valid and can be (re)triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant