fix(voip-server-mumble): cleanup channel listeners when client is freed #3745
+42
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Remove mubmle channel listeners when a client gets freed in order to prevent newly connected users form listening to channels that were left behind by the previous owner of that session id.
How is this PR achieving the goal
It adds new methods to the
ChannelListenerclass that erase all the channels the user is listening to from both maps at once. I didn't use the exsiting API since that would mean holding the mutex per channel instead of once for the whole operation.This PR applies to the following area(s)
Server
Successfully tested on
Platforms: Windows
Checklist