ci: upgrade artifact actions to v4

[gatoniel]

fixes #1398

[bosd]

Why are these % raw tags needed?

[gatoniel]

Otherwise the line would look like this:

          name: coverage-data-${{"{{"}} matrix.python {{"}}"}}-${{"{{"}} matrix.os {{"}}"}}

This was suggested by @webknjaz

[webknjaz]

@bosd it's usually cleaner to wrap chunks of mustache that shouldn't be rendered this way. I find that seeing {{ '{{' }} all over the place doesn't help readability.

[bosd]

I think a codecov token should be added as well.
As we did over here: py-pdf/pypdf_table_extraction@f494056

[gatoniel]

I think a codecov token should be added as well. As we did over here: py-pdf/pypdf_table_extraction@f494056

Shouldn't this be done in a separate pull request as it is about bumping codecov/codecov-action@v3.1.4 to version 4.

[webknjaz]

@gatoniel tokens are mandatory in v4 and v5 of the action (by the way, v5 was released several days ago so maybe you could bump to that).

Though, secrets are inaccesible in forks and this upload method tends to make uploads in PRs from forks less stable. The solution many have found is storing the token in plain text instead of repo secrets. It's not that secret, anyway. I like putting it into the config file codecov.yml so it's not copied across several action invocations.

OTOH, Codecov has recently introduced an org-level toggle on the web UI to disable requiring tokens for uploads. I haven't tried it but it seems like it might eliminate the need to use tokens again..

[gatoniel]

I can try to also add the codecov version bump to this PR. But I thought, this could be done in a different PR as this PR is dedicated to bumping the artifact upload/download action.

[webknjaz]

Oh, I got confused and thought you were bumping codecov for a minute. I that case, it's out of the scope, you're right.

[gatoniel]

Oh, I got confused and thought you were bumping codecov for a minute. I that case, it's out of the scope, you're right.

I don't mind doing it, in a separate PR.

But is this project going to be continued or are there other cookiecutters getting more attention for python projects as this one is not supporting major new developments in the python community? I am too outside of the active community to see these developments :( But, I've heard people stop using poetry and switching to other builders, version managers?

[webknjaz]

There's one by Simon Willison: https://github.com/simonw/python-lib