feat: add missing User struct fields #461
Merged
+130
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduprey
force-pushed
the
kenton/user-3746-add-missing-fields-on-user-struct-in-clerk-sdk-go
branch
from
f23b38e to
ce719d8
Compare
jfoshee
reviewed
Oct 20, 2025
email_address.go
Outdated
| Reserved bool `json:"reserved"` | ||
| Verification *Verification `json:"verification"` | ||
| LinkedTo []*LinkedIdentification `json:"linked_to"` | ||
| MatchesSsoConnection bool `json:"matches_sso_connection"` |
There was a problem hiding this comment.
Should this be MatchesSSOConnection or do we have an existing style exception for this?
Contributor
Author
There was a problem hiding this comment.
This is currently the same name as what is in our main Go repo.
There was a problem hiding this comment.
Granted. But I'm not convinced that because we are not following Go conventions in our internal repo, that we should let that unduly influence our public Go repo. If we decide to rename this later it becomes a breaking change for our customers. But internally we can usually rename more easily. So I think we should try to "get it right the first time" in this repo.
- Add `EnterpriseAccount` type with SAML/OAuth enterprise connection support - Enhance `User` struct with new fields: - `CreatedAt`, `UpdatedAt`, `MFAEnabledAt`, `MFADisabledAt`, `LegalAcceptedAt` - `EnterpriseAccounts` for enterprise SSO support - Update `EmailAddress` with `MatchesSsoConnection` field - Add shared `Verification` and `LinkedIdentification` types Signed-off-by: Kenton Duprey <[email protected]>
kduprey
force-pushed
the
kenton/user-3746-add-missing-fields-on-user-struct-in-clerk-sdk-go
branch
from
ce719d8 to
5013049
Compare
kduprey
changed the title
…ction and samlAccountConnection structs Signed-off-by: Kenton Duprey <[email protected]>
…elds Signed-off-by: Kenton Duprey <[email protected]>
kduprey
changed the title
…OrganizationMembershipPublicUserData struct Signed-off-by: Kenton Duprey <[email protected]>
… and add ExternalAccount.PhoneNumber - Export `EnterpriseAccountConnection` type to make it publicly accessible - Add `PhoneNumber` field to `ExternalAccount` struct - Update `SAMLConnection` field references to use exported type Signed-off-by: Kenton Duprey <[email protected]>
kduprey
deleted the
kenton/user-3746-add-missing-fields-on-user-struct-in-clerk-sdk-go
branch
kduprey
added a commit
that referenced
this pull request
Oct 21, 2025
* feat: add missing User struct fields - Add `EnterpriseAccount` type with SAML/OAuth enterprise connection support - Enhance `User` struct with new fields: - `CreatedAt`, `UpdatedAt`, `MFAEnabledAt`, `MFADisabledAt`, `LegalAcceptedAt` - `EnterpriseAccounts` for enterprise SSO support - Update `EmailAddress` with `MatchesSsoConnection` field - Add shared `Verification` and `LinkedIdentification` types Signed-off-by: Kenton Duprey <[email protected]> * refactor: clean up deprecated Domain fields in enterpriseAccountConnection and samlAccountConnection structs Signed-off-by: Kenton Duprey <[email protected]> * fix: correct casing for MatchesSSOConnection and AllowIDPInitiated fields Signed-off-by: Kenton Duprey <[email protected]> * feat: add message field to Verification struct and username field to OrganizationMembershipPublicUserData struct Signed-off-by: Kenton Duprey <[email protected]> * feat: export EnterpriseAccountConnection, SAMLAccountConnection types and add ExternalAccount.PhoneNumber - Export `EnterpriseAccountConnection` type to make it publicly accessible - Add `PhoneNumber` field to `ExternalAccount` struct - Update `SAMLConnection` field references to use exported type Signed-off-by: Kenton Duprey <[email protected]> --------- Signed-off-by: Kenton Duprey <[email protected]>
kduprey
added a commit
that referenced
this pull request
Oct 22, 2025
* feat: add missing User struct fields - Add `EnterpriseAccount` type with SAML/OAuth enterprise connection support - Enhance `User` struct with new fields: - `CreatedAt`, `UpdatedAt`, `MFAEnabledAt`, `MFADisabledAt`, `LegalAcceptedAt` - `EnterpriseAccounts` for enterprise SSO support - Update `EmailAddress` with `MatchesSsoConnection` field - Add shared `Verification` and `LinkedIdentification` types Signed-off-by: Kenton Duprey <[email protected]> * refactor: clean up deprecated Domain fields in enterpriseAccountConnection and samlAccountConnection structs Signed-off-by: Kenton Duprey <[email protected]> * fix: correct casing for MatchesSSOConnection and AllowIDPInitiated fields Signed-off-by: Kenton Duprey <[email protected]> * feat: add message field to Verification struct and username field to OrganizationMembershipPublicUserData struct Signed-off-by: Kenton Duprey <[email protected]> * feat: export EnterpriseAccountConnection, SAMLAccountConnection types and add ExternalAccount.PhoneNumber - Export `EnterpriseAccountConnection` type to make it publicly accessible - Add `PhoneNumber` field to `ExternalAccount` struct - Update `SAMLConnection` field references to use exported type Signed-off-by: Kenton Duprey <[email protected]> --------- Signed-off-by: Kenton Duprey <[email protected]>
kduprey
added a commit
that referenced
this pull request
Oct 22, 2025
* feat: add missing User struct fields - Add `EnterpriseAccount` type with SAML/OAuth enterprise connection support - Enhance `User` struct with new fields: - `CreatedAt`, `UpdatedAt`, `MFAEnabledAt`, `MFADisabledAt`, `LegalAcceptedAt` - `EnterpriseAccounts` for enterprise SSO support - Update `EmailAddress` with `MatchesSsoConnection` field - Add shared `Verification` and `LinkedIdentification` types * refactor: clean up deprecated Domain fields in enterpriseAccountConnection and samlAccountConnection structs * fix: correct casing for MatchesSSOConnection and AllowIDPInitiated fields * feat: add message field to Verification struct and username field to OrganizationMembershipPublicUserData struct * feat: export EnterpriseAccountConnection, SAMLAccountConnection types and add ExternalAccount.PhoneNumber - Export `EnterpriseAccountConnection` type to make it publicly accessible - Add `PhoneNumber` field to `ExternalAccount` struct - Update `SAMLConnection` field references to use exported type --------- Signed-off-by: Kenton Duprey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EnterpriseAccounttype with SAML/OAuth enterprise connection supportUserstruct with new fields:CreatedAt,UpdatedAt,MFAEnabledAt,MFADisabledAt,LegalAcceptedAtEnterpriseAccountsfor enterprise SSO supportEmailAddresswithMatchesSsoConnectionfieldVerificationandLinkedIdentificationtypes