feat: Updating sdk to use the new API version #465
Merged
+483
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to update the sdk to use the new API version. This PR also contains updates to some of the billing types reflected in the new API version.
paddycarver
requested changes
Nov 4, 2025
Contributor
paddycarver
left a comment
paddycarver
left a comment
There was a problem hiding this comment.
Mostly just tweaks around naming and omitempty. Pointers would be more appropriate in some cases, I think. And even when serializing, omitempty has no effect on non-pointer structs. :(
mzhong9723
approved these changes
Nov 10, 2025
Member
mzhong9723
left a comment
mzhong9723
left a comment
There was a problem hiding this comment.
@paddycarver may have to give it an approval before merging is unblocked though!
paddycarver
reviewed
Nov 10, 2025
paddycarver
approved these changes
Nov 10, 2025
l-armstrong
deleted the
lamone/bill-1381-update-clerk-sdk-go-to-use-new-api-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to update the sdk to use the new API version. This PR also contains updates to some of the billing types reflected in the new API version.