fix(clerk-js): preserve indefinite session deadlines by swolfand · Pull Request #9871 · clerk/javascript

swolfand · 2026-09-22T20:28:19Z

Description

Preserve zero expiration and abandonment timestamps through session loading and snapshots. Add hasMaximumLifetime to session resources so native and Expo clients can distinguish indefinite sessions from finite deadlines.

Load a session with expire_at: 0, restore its snapshot, and verify that the deadline remains zero and hasMaximumLifetime is false. Release before enabling the backend native-session policy.

Part of MOBILE-517. Companion PRs:

Backend: clerk/clerk_go#22459, clerk/clerk_go#22460, clerk/clerk_go#22461, clerk/clerk_go#22462, clerk/clerk_go#22369
Native SDKs: feat(api): expose whether sessions have a maximum lifetime clerk-android#960, feat(sessions): expose whether sessions have a maximum lifetime clerk-ios#576
Dashboard: clerk/dashboard#10297
Edge: clerk/cloudflare-workers#2839
Docs: clerk/clerk#3422

Checklist

pnpm test runs as expected. @clerk/shared, @clerk/clerk-js, and @clerk/expo unit tests passed; full monorepo suite not run.
pnpm build runs as expected. @clerk/shared, @clerk/clerk-js, and @clerk/expo builds passed; full monorepo build not run.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Preserve zero timestamps through date conversion and snapshots, and expose hasMaximumLifetime on session resources. Part of MOBILE-517

changeset-bot · 2026-09-22T20:28:25Z

🦋 Changeset detected

Latest commit: 53c1fed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/shared	Minor
@clerk/chrome-extension	Patch
@clerk/electron	Patch
@clerk/expo	Patch
@clerk/mosaic	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/expo-passkeys	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/hono	Patch
@clerk/localizations	Patch
@clerk/msw	Patch
@clerk/nextjs	Patch
@clerk/nuxt	Patch
@clerk/react-router	Patch
@clerk/react	Patch
@clerk/swingset	Patch
@clerk/tanstack-react-start	Patch
@clerk/testing	Patch
@clerk/ui	Patch
@clerk/vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-09-22T20:28:26Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 069d4c9d-4677-4228-8a50-07354c70367d

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3a07d and 53c1fed.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 16e7f4e2-6bd5-4157-ac27-6452d1e2d48c

📥 Commits

Reviewing files that changed from the base of the PR and between baa8e61 and 7b3a07d.

📒 Files selected for processing: 2

packages/backend/src/api/resources/Session.ts
packages/shared/src/types/session.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-android (auto-detected) → reviewed against open PR #960 sam/mobile-session-lifetimes instead of the default branch
clerk/clerk-ios (auto-detected) → reviewed against open PR #576 sam/mobile-session-lifetimes instead of the default branch
clerk/cli (auto-detected)

Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

📝 Walkthrough

unixEpochToDate now preserves an explicit zero timestamp. Session and SessionWithActivities expose hasMaximumLifetime, and shared session types document the property. Tests cover deadline values and maximum-lifetime status after snapshot restoration, including restored client sessions.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: wobsoriano, sarahsoutoul

Merge Risk: ⚪ Minimal · up to 7b3a0

Zero-valued indefinite-session deadlines are preserved through restoration, and the lifetime indicator is exposed. No actionable merge-blocking issue was found in the changed boundaries.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 8 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: preserving indefinite session deadlines in Clerk JS.
Description check		The description directly explains the deadline preservation, snapshot restoration, and new hasMaximumLifetime property. It matches the changeset.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

vercel · 2026-09-22T20:28:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Oct 16, 2026 1:03am UTC
swingset	Ready	Preview	Oct 16, 2026 1:03am UTC

pkg-pr-new · 2026-09-22T20:32:33Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9871

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9871

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9871

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9871

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9871

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9871

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9871

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9871

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@9871

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9871

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@9871

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9871

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9871

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9871

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9871

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9871

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9871

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9871

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9871

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9871

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9871

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9871

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9871

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9871

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9871

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9871

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9871

commit: 53c1fed

…fetimes

…napshot Part of MOBILE-517

hasMaximumLifetime is a new public property, so clerk-js and shared take a minor bump. The changeset now describes the user-facing fix. Part of MOBILE-517

github-actions · 2026-10-14T17:12:24Z

API Changes Report

Generated by Break Check on 2026-10-16T01:04:58.345Z

Summary

Metric	Count
Packages analyzed	20
Packages with changes	1
🔴 Breaking changes	0
🟡 Non-breaking changes	0
🟢 Additions	2

@clerk/shared

Current version: 4.40.0
Recommended bump: MINOR → 4.41.0

Subpath `./types`

🟢 Additions (2)

Added: `SessionResource.hasMaximumLifetime`

+ readonly hasMaximumLifetime?: boolean;

Added property SessionResource.hasMaximumLifetime

Added: `SessionWithActivitiesResource.hasMaximumLifetime`

+ readonly hasMaximumLifetime?: boolean;

Added property SessionWithActivitiesResource.hasMaximumLifetime

Report generated by Break Check

_{Last ran on 53c1fed.}

wobsoriano

looks good! pushed a tiny change

SarahSoutoul · 2026-10-16T00:22:15Z

@swolfand Explained everything in the accompanying docs PR, but pushed some JSDoc changes to include some of that info you had in the docs before but are better included as part of the property in the Typedoc output. Have a look and let me know if that looks good to you.

fix(clerk-js): preserve indefinite session deadlines

035ae20

Preserve zero timestamps through date conversion and snapshots, and expose hasMaximumLifetime on session resources. Part of MOBILE-517

github-actions Bot added the clerk-js label Sep 22, 2026

vercel Bot deployed to Preview – swingset September 22, 2026 20:30

View deployment

swolfand added 3 commits October 13, 2026 21:43

Merge remote-tracking branch 'origin/main' into sam/mobile-session-li…

55359d6

…fetimes

test(clerk-js): cover restoring an indefinite session from a client s…

62e3c17

…napshot Part of MOBILE-517

docs(shared): document hasMaximumLifetime and mark the change as minor

18db78f

hasMaximumLifetime is a new public property, so clerk-js and shared take a minor bump. The changeset now describes the user-facing fix. Part of MOBILE-517

vercel Bot deployed to Preview – clerk-js-sandbox October 14, 2026 04:54

View deployment

vercel Bot deployed to Preview – swingset October 14, 2026 04:57

View deployment

This was referenced Oct 14, 2026

feat(sessions): expose whether sessions have a maximum lifetime clerk/clerk-ios#576

Open

feat(api): expose whether sessions have a maximum lifetime clerk/clerk-android#960

Open

swolfand marked this pull request as ready for review October 14, 2026 17:07

chore(repo): tighten native session lifetime changeset

baa8e61

vercel Bot deployed to Preview – clerk-js-sandbox October 15, 2026 21:24

View deployment

wobsoriano approved these changes Oct 15, 2026

View reviewed changes

vercel Bot deployed to Preview – swingset October 15, 2026 21:25

View deployment

swolfand mentioned this pull request Oct 15, 2026

fix(clerk-js): Preserve indefinite session deadlines (Core 2) #10269

Draft

3 of 9 tasks

SarahSoutoul mentioned this pull request Oct 16, 2026

docs(session): explain indefinite native session fields #10270

Closed

3 of 9 tasks

docs(session): explain indefinite native session fields

1538f12

github-actions Bot added the backend label Oct 16, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 16, 2026 00:18

View deployment

docs(session): omit unpublished native section links

7b3a07d

vercel Bot deployed to Preview – clerk-js-sandbox October 16, 2026 00:20

View deployment

vercel Bot deployed to Preview – swingset October 16, 2026 00:22

View deployment

Merge branch 'main' into sam/mobile-session-lifetimes

53c1fed

vercel Bot deployed to Preview – clerk-js-sandbox October 16, 2026 01:01

View deployment

vercel Bot deployed to Preview – swingset October 16, 2026 01:03

View deployment

Navigation Menu

Repository navigation

fix(clerk-js): preserve indefinite session deadlines - #9871

fix(clerk-js): preserve indefinite session deadlines#9871
swolfand wants to merge 8 commits into
mainfrom
sam/mobile-session-lifetimes

swolfand commented Sep 22, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 22, 2026 •

edited

Loading

Review skipped

Uh oh!

vercel Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

wobsoriano left a comment

Uh oh!

SarahSoutoul commented Oct 16, 2026 •

edited

Loading

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

swolfand commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

vercel Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Changes Report

Summary

@clerk/shared

Subpath ./types

🟢 Additions (2)

Added: SessionResource.hasMaximumLifetime

Added: SessionWithActivitiesResource.hasMaximumLifetime

Uh oh!

wobsoriano left a comment

Choose a reason for hiding this comment

Uh oh!

SarahSoutoul commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

swolfand commented Sep 22, 2026 •

edited

Loading

changeset-bot Bot commented Sep 22, 2026 •

edited

Loading

coderabbitai Bot commented Sep 22, 2026 •

edited

Loading

vercel Bot commented Sep 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Subpath `./types`

Added: `SessionResource.hasMaximumLifetime`

Added: `SessionWithActivitiesResource.hasMaximumLifetime`

SarahSoutoul commented Oct 16, 2026 •

edited

Loading