Conversation
🦋 Changeset detectedLatest commit: 8c5d287 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
9 tasks
Adds an engine-agnostic behavior suite for JS <-> native client sync, backed by a fake Frontend API, a fake native SDK, and a clerk-js stand-in, with a thin adapter that drives today's ClerkProvider engine. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mikepitre
force-pushed
the
mike/expo-native-sync-behavior-tests
branch
from
September 27, 2026 14:50
544222b to
8c5d287
Compare
mikepitre
changed the base branch from
main
to
mike/expo-native-sync-bridge
September 27, 2026 14:50
This was referenced Sep 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an engine-agnostic behavioral test suite for the
@clerk/expoJS <-> native client sync, so it can gate the upcoming replacement of the sync engine (native owns the device token, payload-free invalidations in both directions).The suite lives in
packages/expo/src/provider/__tests__/nativeClientSyncBehavior/and asserts only user-observable outcomes: the JS signed-in state and active session, the native token and client view, request and refresh counts, the absence of signed-out emissions during session switches, and errors surfaced through the sync barrier. It is backed by:FakeClerkServer: one Frontend API shared by both SDKs, with clients keyed by device token.FakeNativeClerk: the native SDK's persisted token, its client view, and native-originated actions and change notifications.FakeClerk: a stand-in for the clerk-js instance returned bygetClerkInstance, using the same surface the existingClerkProvidertests mock. It talks to the fake Frontend API through the token cache it is built with, likecreateClerkInstance.currentEngineAdapter:renderWithNativeSync(scenario)for today's engine. It keeps today's native module contract (configure,getClientToken,syncClientStateFromJs,clerkNativeClientChangedpayloads andsourceIdtags) out of the tests. To run the suite against a new engine, only the export inindex.tsneeds to point at a new adapter.Two behaviors the current engine does not meet yet are kept as
it.failsunder "known gaps in the current engine". They should flip toitonce the new engine lands:configureadopts the JS bearer token.The existing
ClerkProvider.nativeClientSyncand coordinator tests are unchanged.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code