-
Notifications
You must be signed in to change notification settings - Fork 668
Build all of the typescript templates in CI #3980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different packages/examples
drogus
approved these changes
Jan 12, 2026
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some tests are failing, but once you solve them I think it's fine to merge
1 task
…' into jsdt/ts-test-build-all
…fix-b8-build' into jsdt/ts-test-build-all
auto-merge was automatically disabled
January 13, 2026 17:49
Merge commits are not allowed on this repository
…to bfops/fix-b8-build
…fix-b8-build' into jsdt/ts-test-build-all
Collaborator
|
Sorry for all the review pings 😅 I changed base branch before updating branches which temporarily made the diff huge. |
…fix-b8-build' into jsdt/ts-test-build-all
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
# Description of Changes See #3921 for a previous version of this PR. Just expanding that hacky fix. # API and ABI breaking changes CI-only change. # Expected complexity level and risk 1 # Testing - [x] Build fixed in #3980 --------- Co-authored-by: Zeke Foppa <[email protected]>
kistz
pushed a commit
to kistz/SpacetimeDB
that referenced
this pull request
Jan 13, 2026
# Description of Changes See clockworklabs#3921 for a previous version of this PR. Just expanding that hacky fix. # API and ABI breaking changes CI-only change. # Expected complexity level and risk 1 # Testing - [x] Build fixed in clockworklabs#3980 --------- Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also has a few minor changes to fix build errors for the
test-app.Description of Changes
Updates the typescript-test CI job to build some packages that weren't being built before.
This also updates the root-level
pnpm generate/format/lint/buildcommands to also apply to templates.Expected complexity level and risk
1