Skip to content

Conversation

@jsdt
Copy link
Contributor

@jsdt jsdt commented Jan 8, 2026

This also has a few minor changes to fix build errors for the test-app.

Description of Changes

Updates the typescript-test CI job to build some packages that weren't being built before.

This also updates the root-level pnpm generate/format/lint/build commands to also apply to templates.

Expected complexity level and risk

1

@jsdt jsdt requested a review from drogus January 9, 2026 18:30
@jsdt jsdt changed the title Build all of the typescript examples in CI Build all of the typescript templates in CI Jan 9, 2026
Copy link
Collaborator

@drogus drogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some tests are failing, but once you solve them I think it's fine to merge

@bfops bfops added the release-any To be landed in any release window label Jan 12, 2026
@jsdt jsdt enabled auto-merge January 12, 2026 21:58
@bfops bfops mentioned this pull request Jan 13, 2026
1 task
@bfops bfops changed the base branch from master to bfops/fix-b8-build January 13, 2026 17:49
@bfops bfops requested review from Centril and jdetter as code owners January 13, 2026 17:49
auto-merge was automatically disabled January 13, 2026 17:49

Merge commits are not allowed on this repository

@bfops
Copy link
Collaborator

bfops commented Jan 13, 2026

Sorry for all the review pings 😅 I changed base branch before updating branches which temporarily made the diff huge.

github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
# Description of Changes

See #3921 for a
previous version of this PR. Just expanding that hacky fix.

# API and ABI breaking changes

CI-only change.

# Expected complexity level and risk

1

# Testing

- [x] Build fixed in
#3980

---------

Co-authored-by: Zeke Foppa <[email protected]>
@bfops bfops changed the base branch from bfops/fix-b8-build to master January 13, 2026 21:46
kistz pushed a commit to kistz/SpacetimeDB that referenced this pull request Jan 13, 2026
# Description of Changes

See clockworklabs#3921 for a
previous version of this PR. Just expanding that hacky fix.

# API and ABI breaking changes

CI-only change.

# Expected complexity level and risk

1

# Testing

- [x] Build fixed in
clockworklabs#3980

---------

Co-authored-by: Zeke Foppa <[email protected]>
@jsdt jsdt added this pull request to the merge queue Jan 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2026
@bfops bfops added this pull request to the merge queue Jan 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2026
@bfops bfops added this pull request to the merge queue Jan 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2026
@bfops bfops added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit dc51635 Jan 14, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants