Handle database states better when serving module logs #3984
+209
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stacked on top of #3961 |
kim
force-pushed
the
kim/in-memory-module-logs
branch
from
c7ad80b to
edb5dc8
Compare
kim
force-pushed
the
kim/in-memory-module-logs
branch
from
edb5dc8 to
38524a5
Compare
If a database is not currently running / runnable, we can still serve module logs if, and only if, the routing layer has correctly picked the last known leader. To determine that this is the case, we make it so a predicate can be evaluated against the error return of `NodeDelegate::leader`. In the future, we may be able to fetch from the last known leader transparently, or store module logs in distributed storage altogether, at which point the predicate trait can be retired. In order to not leak information about the server's directory structure, `DatabaseLogger::read_latest_on_disk` will return an empty stream in case no log directory or recent log file exist on disk.
kim
force-pushed
the
kim/in-memory-module-logs
branch
from
38524a5 to
84ff62d
Compare
gefjon
approved these changes
Jan 15, 2026
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Much better error messages, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a database is not currently running / runnable, we can still serve module logs if, and only if, the routing layer has correctly picked the last known leader.
To determine that this is the case, we make it so a predicate can be evaluated against the error return of
NodeDelegate::leader.In the future, we may be able to fetch from the last known leader transparently, or store module logs in distributed storage altogether, at which point the predicate trait can be retired.
In order to not leak information about the server's directory structure,
DatabaseLogger::read_latest_on_diskwill return an empty stream in case no log directory or recent log file exist on disk.Expected complexity level and risk
1.5
Testing
n/a