Unreal SDK failing to handle fragmented messages #4002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changed to OnBinaryMessage to properly handle message fragmentation introduced recently
Contributor
|
Found this as well. Check my PR here, I did something different to fix it in my project. Is working reliably: |
rekhoff
approved these changes
Jan 12, 2026
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Code looks clean and targets the root problem with minimal changes. Tested Blackholio locally and confirmed no errors found.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kistz
pushed a commit
to kistz/SpacetimeDB
that referenced
this pull request
Jan 13, 2026
# Description of Changes Updated the handler from OnRawMessage to OnBinaryMessage as OnRawMessage seems to have a bug that won't report the BytesRemaining for incomplete messages. OnBinaryMessage properly returns a bool flag like how the C# implementation works. # API and ABI breaking changes N/A # Expected complexity level and risk 2 - Underlying framework change on how messages are handled # Testing Blackholio was no longer working and is back in working order; however Unreal test framework has been broken due to the work on Result<> as the companion PR has not been merged. - [x] Rebuilt and ran Unreal Blackholio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updated the handler from OnRawMessage to OnBinaryMessage as OnRawMessage seems to have a bug that won't report the BytesRemaining for incomplete messages. OnBinaryMessage properly returns a bool flag like how the C# implementation works.
API and ABI breaking changes
N/A
Expected complexity level and risk
2 - Underlying framework change on how messages are handled
Testing
Blackholio was no longer working and is back in working order; however Unreal test framework has been broken due to the work on Result<> as the companion PR has not been merged.