Skip to content

Conversation

@kistz
Copy link
Contributor

@kistz kistz commented Jan 13, 2026

Description of Changes

Dpends on and includes: #4011
Will remove commits whenever that merges 👍

This impacts the useTable() functions whereclause.
We add a new possibility for the Value type which is the new Uuid type.

Also my formatter is bugging again :( whenever i pnpm format it does things differently than the guidelines? Would be cool for that reason if someone can run format for me maybe bfops like the last time :>

API and ABI breaking changes

None

Expected complexity level and risk

  1. Only lifts the filter for the where clause a bit to further support Uuid alongside bool, string, and number.

Testing

  • Getting syntax highlithing for the new availbale row
  • Getting row back from subscription when supplying a uuid
  • Fix edge case with string

@kistz kistz marked this pull request as ready for review January 13, 2026 23:21
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2026

CLA assistant check
All committers have signed the CLA.

@kistz kistz marked this pull request as draft January 13, 2026 23:47
@kistz
Copy link
Contributor Author

kistz commented Jan 13, 2026

Uhhh woops did the wrong git command ^^

I thought i squashed it but something went wrong now im not sure anymore how to best revert this 🥴 @bfops is this a problem that i should fix or is the squashing while merging going to be enough? ^^

@egormanga
Copy link
Contributor

im not sure anymore how to best revert this

I believe you can just do a git rebase -i over whatever branch you're basing it on (most probably, origin/master) and choose the commits for squashing, not touching your relevant ones.

@bfops bfops force-pushed the react-uuid-in-where-clause branch from 39e1e25 to a91383f Compare January 14, 2026 20:13
@bfops
Copy link
Collaborator

bfops commented Jan 14, 2026

Thank you for opening this! We'll work on getting it reviewed.

In the meantime, I rebased and ran pnpm format.

@kistz
Copy link
Contributor Author

kistz commented Jan 14, 2026

Thank you very much bfops! :>

@kistz kistz marked this pull request as ready for review January 14, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants