Add missing peer dependencies#153
Open
atlekbai wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the peer dependencies that the starter already relies on indirectly:
@babel/corefor@rolldown/plugin-babel@ai-sdk/providerforworkers-ai-provider@ai-sdk/reactfor@cloudflare/ai-chat/reactNo source code changes are needed.
Why
I hit this from a fresh project created with the Agents starter.
npm run devfailed before Vite could load the config because@rolldown/plugin-babelimports@babel/core, but the app does not declare it:Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@babel/core' imported from .../node_modules/@rolldown/plugin-babel/dist/index.mjs
Once that was fixed, the Worker and client transforms also needed the AI SDK peers used by
workers-ai-providerand@cloudflare/ai-chat/react.Declaring these at the app root makes fresh installs deterministic instead of relying on where npm happens to place transitive peer dependencies.
Validation
npm cinpm run checknpm run devcurl -I http://127.0.0.1:5173/returned200