fix(types): filter symbol keys in RpcCompatible mapped type #129
Conversation
🦋 Changeset detectedLatest commit: 781c775 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
All contributors have signed the CLA ✍️ ✅ |
commit: |
|
I have read the CLA Document and I hereby sign the CLA |
dmmulroy
force-pushed
the
fix-rpccompatible-symbol-keys
branch
from
b6b49b3 to
8bb2fb9
Compare
|
Hmm it appears you ran some sort of auto-formatter on this file and it added some extraneous diffs, can you reduce it to just the intended change please? (Cap'n Web doesn't currently use auto-formatting because I personally can't stand them but I imagine someone will insist on adding one at some point and I will relent... but for the moment, there isn't one.) |
|
ah yeah that likely happened, will fix up. |
Use key remapping to filter out symbol keys instead of mapping to never. Fixes Disposable compatibility issue with RPC types. Ref: cloudflare/workerd#5804
dmmulroy
force-pushed
the
fix-rpccompatible-symbol-keys
branch
from
8bb2fb9 to
781c775
Compare
|
done 🫡 |
2 participants
Summary
Use key remapping (
asclause) to filter out symbol keys instead of mapping them tonever. FixesDisposablecompatibility issue with RPC types.Context
Per @kentonv's review comment on cloudflare/workerd#5804 - applying the same fix here.
Change
Note
This PR was written with AI assistance.
AI Session Export
{ "info": { "title": "capnweb rpccompatible symbol fix", "agent": "opencode", "models": ["claude opus 4.5"] }, "summary": [ "user requested review of workerd PR #5804", "agent fetched PR details and Kenton's comment about updating capnweb", "agent cloned capnweb to ~/Code/work/ using jj", "agent applied same RpcCompatible fix to src/types.d.ts", "agent created PR referencing workerd#5804" ] }