Fix parsing yaml, init with genconfig, versioning#116
Open
ChrisChoke wants to merge 4 commits intocloudflare:masterfrom
Open
Fix parsing yaml, init with genconfig, versioning#116ChrisChoke wants to merge 4 commits intocloudflare:masterfrom
ChrisChoke wants to merge 4 commits intocloudflare:masterfrom
Conversation
this fix let us run version, help and genconfig command if certmgr is not initialized with config dir and specdir.
change to git describe --tags to include lightweight tags for versioning
- fix recursion issue (stack overflow fatal err)
- fix ParsableAuthority struct with embedded struct for yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address to #115 ref
#114, #107
with this PR you can use yaml for spec files again.
it let us use "certmgr genconfig" again
and inject the latest tag to version while building even it is "lightweight tag" (git tag -lw).