add thread-safe tockenbucket touch() function#42
Open
kerolasa wants to merge 1 commit intocloudflare:masterfrom
Open
add thread-safe tockenbucket touch() function#42kerolasa wants to merge 1 commit intocloudflare:masterfrom
kerolasa wants to merge 1 commit intocloudflare:masterfrom
Conversation
Making the touch() thread-safe allows removing external mutex(es) that protect calling the touch. Unarguably the change also makes the data racing more, but that is fine. With low frequency updates the tocket bucket will not trip over, and with high frequency updates one should not be able to observe off-by-one type of return value distortion when values are stored few jiffies apart. Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the touch() thread-safe allows removing external mutex(es) that protect calling the touch.
Unarguably the change also makes the data racing more, but that is fine. With low frequency updates the tocket bucket will not trip over, and with high frequency updates one should not be able to observe off-by-one type of return value distortion when values are stored few jiffies apart.
Signed-off-by: Sami Kerola kerolasa@cloudflare.com