fix: keep mobile sidebar open for portaled focus#623
Merged
mattrothenberg merged 1 commit intoJul 9, 2026
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
mattrothenberg
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Fixes #604
Summary
Fixes the mobile Sidebar closing unexpectedly when focus moves outside the sidebar into portaled interactive content, such as dropdown menus or popovers rendered from inside the sidebar.
The mobile Sidebar now closes on explicit dismissal actions only:
Changes
focusoutlistener that closed the drawer when focus moved outside the sidebar DOM subtree.@cloudflare/kumo.Validation
pnpm --filter @cloudflare/kumo test:unit src/components/sidebar/sidebar.test.tsxpnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo lintReviews
Tests