-
Notifications
You must be signed in to change notification settings - Fork 516
add no-export-default-of-import-star eslint rule #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ab947c3 to
dd3facb
Compare
Merging this PR will degrade performance by 18.54%
Performance Changes
Comparing Footnotes
|
|
Ordinarily this could be a potentially breaking change but I think we may have lucked out. If any of the internal modules had default exports then changing things like this could have broken existing code... for instance, suppose the internal_timers_promises.ts had a default export, existing code could have been doing something like... import ntp from 'node:timers/promises';
ntp.default.whatever();But in each of the changed cases there are no default exports. I think we're likely safe! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, I verified that the PR fixes the issue with Next 16.1 🎉
Thanks @anonrig and @jasnell !
Could you please add a test in this PR (move the one I added in #5847 here instead)
We should probably update the PR title to reflect the main fix.
I also added a couple minor comments
Feel free to discard my review when comments are addressed
dd3facb to
b01104b
Compare
b01104b to
5c7bc07
Compare
|
Woohoo, thanks ! |
Fixes a portion of #5844
Adds a rule to disallow certain usages across the node.js directory.