Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jan 12, 2026

Fixes a portion of #5844

Adds a rule to disallow certain usages across the node.js directory.

@anonrig anonrig requested review from a team and jasnell January 12, 2026 22:00
@anonrig anonrig requested review from a team as code owners January 12, 2026 22:00
@anonrig anonrig force-pushed the yagiz/fix-default-export-start branch from ab947c3 to dd3facb Compare January 12, 2026 22:03
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

Merging this PR will degrade performance by 18.54%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 138 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
jsonResponse[Response] 34.9 µs 42.8 µs -18.54%
simpleStringBody[Response] 21.7 µs 19.2 µs +12.93%

Comparing yagiz/fix-default-export-start (5c7bc07) with main (5f00731)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@jasnell
Copy link
Collaborator

jasnell commented Jan 12, 2026

Ordinarily this could be a potentially breaking change but I think we may have lucked out. If any of the internal modules had default exports then changing things like this could have broken existing code... for instance, suppose the internal_timers_promises.ts had a default export, existing code could have been doing something like...

import ntp from 'node:timers/promises';
ntp.default.whatever();

But in each of the changed cases there are no default exports. I think we're likely safe!

@anonrig anonrig enabled auto-merge (squash) January 12, 2026 22:27
vicb
vicb previously requested changes Jan 13, 2026
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, I verified that the PR fixes the issue with Next 16.1 🎉

Thanks @anonrig and @jasnell !

Could you please add a test in this PR (move the one I added in #5847 here instead)

We should probably update the PR title to reflect the main fix.

I also added a couple minor comments

Feel free to discard my review when comments are addressed

@anonrig anonrig force-pushed the yagiz/fix-default-export-start branch from b01104b to 5c7bc07 Compare January 13, 2026 20:42
@anonrig anonrig merged commit 96f948e into main Jan 13, 2026
32 of 33 checks passed
@anonrig anonrig deleted the yagiz/fix-default-export-start branch January 13, 2026 21:26
@vicb
Copy link
Contributor

vicb commented Jan 14, 2026

Woohoo, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants