Skip to content

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Jan 21, 2026

No description provided.

This requires building with cache disabled so that we can confirm whether
outputs for the affected actions are created properly with symlinks disabled.
@fhanau
Copy link
Contributor Author

fhanau commented Jan 21, 2026

This still doesn't work as of Bazel 9.0.0:

ERROR: C:/a/workerd/workerd/src/node/BUILD.bazel:3:13: Transpiling & type-checking TypeScript project @@//src/node:node@tsproject [tsc -p src/node/tsconfig.json] failed: (Exit 2): tsc.bat failed: error executing TsProject command (from ts_project rule target //src/node:node@tsproject) 
error TS2688: Cannot find type definition file for '@types/node'.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

Merging this PR will degrade performance by 11.5%

❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
simpleStringBody[Response] 19.1 µs 21.6 µs -11.5%

Comparing felix/012026-bazel9-winopt (0eb2aab) with main (d19e973)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant