Skip to content

Fix WABT dependency #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
logan-gatlin wants to merge 1 commit into from
Closed

Fix WABT dependency #6226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions build/deps/build_deps.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,15 @@
"file_regex": "llvm-.*-darwin-arm64-clang-tidy",
"file_type": "executable",
"freeze_version": "clang-tidy-22.1.0"
},
{
"name": "deps_wabt",
"type": "github_release",
"owner": "WebAssembly",
"repo": "wabt",
"file_regex": "wabt-.*-ubuntu-20.04\\.tar\\.gz$",
"build_file": "//:build/BUILD.wabt",
"freeze_version": "1.0.37" // 1.0.38 doesn't have ubuntu tar.gz, 1.0.39 has a Linux binary but requires glibc 2.38 (will need to update to Trixie for that)
Comment on lines +144 to +151
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several issues with this entry:

  1. build_file references a non-existent file: //:build/BUILD.wabt does not exist in the repo. This was not added in this PR or in PR Signal handling for non-Python WASM modules #6154.

  2. deps_wabt is unused: No BUILD file or .bzl rule in the repo references @deps_wabt. The dependency that IS actively used is wasm-tools (referenced by tools/BUILD.bazel and build/wasm_tools_parse.bzl).

  3. The wasm-tools entries in gen/build_deps.MODULE.bazel are still orphaned: They were hand-edited into the generated file by PR Signal handling for non-Python WASM modules #6154 without corresponding source entries here. Running update-deps.py after this PR will delete them and break the build.

I believe the fix should instead add source entries for wasm-tools (one per platform: wasm_tools_linux_x64, wasm_tools_linux_arm64, wasm_tools_macos_x64, wasm_tools_macos_arm64, wasm_tools_windows_x64) to match what's currently in gen/build_deps.MODULE.bazel, and then regenerate the generated file. If wabt is also needed, you'll need to create the BUILD.wabt file and add a reference to @deps_wabt in the appropriate BUILD file.

}
]
}
Loading