Skip to content

Integrate re-init hook#962

Open
logan-gatlin wants to merge 2 commits intomainfrom
reinit-hook
Open

Integrate re-init hook#962
logan-gatlin wants to merge 2 commits intomainfrom
reinit-hook

Conversation

@logan-gatlin
Copy link
Copy Markdown
Collaborator

@logan-gatlin logan-gatlin commented Apr 1, 2026

Simplifies the shim code for the panic=unwind path using the new wasm-bindgen reinit hook. I created a new shim file for panic unwind builds that handles incrementing the instanceId and setting the panic error hook in Rust.

@logan-gatlin logan-gatlin marked this pull request as ready for review April 1, 2026 21:12
@guybedford
Copy link
Copy Markdown
Collaborator

In theory this should now fix this test - https://github.com/cloudflare/workers-rs/blob/main/test/tests/panic.spec.ts#L183.

Can we try that out on this PR?

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 2 untouched benchmarks


Comparing reinit-hook (df2411f) with main (f9d380b)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants