Skip to content

Fix the #[event(start)] regression from v0.8#974

Merged
guybedford merged 4 commits intocloudflare:mainfrom
jakubadamw:issue-973
Apr 13, 2026
Merged

Fix the #[event(start)] regression from v0.8#974
guybedford merged 4 commits intocloudflare:mainfrom
jakubadamw:issue-973

Conversation

@jakubadamw
Copy link
Copy Markdown
Contributor

@jakubadamw jakubadamw commented Apr 12, 2026

Fixes a regression from e363ba6#diff-5fbccf7aad8fecebdb79b59bcdf993ad2236c34b9360b7f6cc2862374497a610L244-R234 that made any use of #[event(start)] fail to compile unless the user crate had a direct dependency on wasm-bindgen.

Closes #973.

@jakubadamw jakubadamw marked this pull request as draft April 12, 2026 15:07
@jakubadamw jakubadamw changed the title Fix #[event(start)] regression in v0.8 Fix the #[event(start)] regression from v0.8 Apr 12, 2026
@jakubadamw jakubadamw marked this pull request as ready for review April 12, 2026 15:19
@jakubadamw jakubadamw marked this pull request as draft April 12, 2026 15:26
@jakubadamw jakubadamw marked this pull request as ready for review April 12, 2026 15:40
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 13, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 2 untouched benchmarks


Comparing jakubadamw:issue-973 (98d14ae) with main (3dfe90e)

Open in CodSpeed

@guybedford guybedford merged commit c6847ba into cloudflare:main Apr 13, 2026
11 checks passed
@guybedford
Copy link
Copy Markdown
Collaborator

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Regression in 0.8.0: Can’t use #[event(start)] without a direct wasm-bindgen dependency

2 participants