Merged
Conversation
These were added during SAML work, should have been removed before merge
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes three shell scripts from the scripts/ directory that were added during SAML development work and should have been cleaned up before the SAML changes were merged.
Changes:
- Removal of
create_test_zones.sh,create_test_providers.sh, andcount_disabled_tests.shhelper scripts
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/create_test_zones.sh |
Removed script that created/deleted SAML test identity zones |
scripts/create_test_providers.sh |
Removed script that created/deleted SAML test identity providers |
scripts/count_disabled_tests.sh |
Removed utility script that counted disabled tests in the project |
No issues found. The three scripts are purely deleted, have no references elsewhere in the codebase, and the PR description clearly explains the rationale for removal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
strehle
approved these changes
Mar 16, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were added during SAML work, should have been removed before merge