Remove unused Kubernetes configurations and custom matchers#3784
Open
Remove unused Kubernetes configurations and custom matchers#3784
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the entire k8s/ directory containing ytt-based Kubernetes template infrastructure (templates, Go test suite with custom Gomega matchers, helper scripts, Makefile, Go module, and test fixtures) and replaces it with a lightweight docs/Running-on-Kubernetes.md guide that documents how to run UAA on Kubernetes using the published Docker image.
Changes:
- Removed all k8s ytt templates, Go tests, custom matchers, scripts, and the Go module (
go.mod/go.sum) - Added
docs/Running-on-Kubernetes.mdwith Docker run and Kubernetes Deployment/Service/Ingress examples - Updated
README.mdto link to the new documentation instead of referencing the removed ytt workflow, and removed thegomodentry from.github/dependabot.yml
Reviewed changes
Copilot reviewed 72 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
docs/Running-on-Kubernetes.md |
New documentation for running UAA on K8s using the Docker image |
README.md |
Replaced ytt-based K8s instructions with a link to new docs |
.github/dependabot.yml |
Removed gomod entry for /k8s directory |
k8s/templates/** |
Deleted all ytt template files (deployment, service, config, secrets, etc.) |
k8s/matchers/** |
Deleted all custom Gomega matcher Go files |
k8s/test/** |
Deleted all Go test files |
k8s/test_fixtures/** |
Deleted all test fixture YAML files |
k8s/scripts/**, k8s/Makefile, k8s/README.md |
Deleted helper scripts, Makefile, and k8s-specific README |
k8s/go.mod, k8s/go.sum |
Deleted Go module files |
k8s/addons/** |
Deleted addon YAMLs (ingress, local testing) |
k8s/image/tomcat/conf/server.xml |
Deleted Tomcat server config |
k8s/run-minikube.sh, k8s/run-uaa-locally-with-rendered-config.sh |
Deleted convenience scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Member
Author
|
concourse-ci/status test fails since it is running the run-k8s-template-tests which no longer exist. We will have to remove those form concourse once we decide to merge |
strehle
approved these changes
Mar 18, 2026
Member
strehle
left a comment
strehle
left a comment
There was a problem hiding this comment.
ok from my side we should remove because with this kind project we have now a k8s CF version which is really easy to use... e.g.
https://github.com/cloudfoundry/kind-deployment
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the repository’s legacy k8s/ ytt-based Kubernetes templating/test harness (including custom Go matchers and fixtures) and replaces the top-level Kubernetes guidance with a simpler “run the published Docker image on Kubernetes” document.
Changes:
- Delete the entire
k8s/templating, scripts, Go test/matcher code, and related fixtures that were no longer referenced. - Add new Kubernetes run documentation under
docs/Running-on-Kubernetes.mdand point the rootREADME.mdto it. - Update repo automation to stop treating
k8s/as a Go module (remove Dependabotgomodentry, remove Go from CodeQL language matrix).
Reviewed changes
Copilot reviewed 73 out of 74 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| k8s/test_fixtures/signing-key-fixture2.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/signing-key-fixture1.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/signing-key-fixture-missing-active-key-id1.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/saml_keys_fixtures_unmatched_active_key_id.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/saml_keys_fixtures_no_key_set_as_active_key_id.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/saml_keys_fixtures_missing_active_key_id_entry.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/saml_keys_fixtures2.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/saml_keys_fixtures1.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/encryption_keys_invalid_key_fixtures.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/encryption_keys_fixtures_no_active_key.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/encryption_keys_fixtures_empty_key.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/encryption_keys_fixtures.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/enable-automount-service-account-token.yml | Removed unused k8s test fixture |
| k8s/test_fixtures/ca_certs.yml | Removed unused k8s test fixture |
| k8s/test/service_test.go | Removed obsolete k8s template tests |
| k8s/test/service_account_test.go | Removed obsolete k8s template tests |
| k8s/test/secrets_test.go | Removed obsolete k8s template/secret rendering tests |
| k8s/test/metadata_test.go | Removed obsolete k8s metadata overlay tests |
| k8s/test/k8s_suite_test.go | Removed obsolete Ginkgo suite bootstrap for k8s tests |
| k8s/test/deployment_test.go | Removed obsolete deployment template tests and custom matchers usage |
| k8s/test/config_map_test.go | Removed obsolete configmap rendering tests |
| k8s/templates/values/version.yml | Removed legacy ytt values file |
| k8s/templates/values/image.yml | Removed legacy ytt values file |
| k8s/templates/values/_values.yml | Removed legacy ytt values schema/defaults |
| k8s/templates/uaa.lib.yml | Removed legacy ytt library used to render uaa.yml |
| k8s/templates/service_account.yml | Removed legacy ytt ServiceAccount template |
| k8s/templates/service.yml | Removed legacy ytt Service template |
| k8s/templates/secrets/smtp_credentials.yml | Removed legacy ytt Secret template |
| k8s/templates/secrets/saml_keys.yml | Removed legacy ytt Secret template |
| k8s/templates/secrets/saml_keys.star | Removed legacy ytt validation helper |
| k8s/templates/secrets/jwt_policy_signing_keys.yml | Removed legacy ytt Secret template |
| k8s/templates/secrets/jwt_policy_signing_keys.star | Removed legacy ytt validation helper |
| k8s/templates/secrets/encryption_keys.yml | Removed legacy ytt Secret template |
| k8s/templates/secrets/encryption_keys.star | Removed legacy ytt validation helper |
| k8s/templates/secrets/database_credentials.yml | Removed legacy ytt Secret template |
| k8s/templates/secrets/ca_certs.yml | Removed legacy ytt Secret template |
| k8s/templates/secrets/ca_certs.star | Removed legacy ytt CA cert helper |
| k8s/templates/secrets/admin_client_credentials.yml | Removed legacy ytt Secret template |
| k8s/templates/metadata.yml | Removed legacy ytt overlay for common metadata labels/namespace |
| k8s/templates/log4j2.properties | Removed legacy log4j2 properties used by k8s templates |
| k8s/templates/deployment.yml | Removed legacy ytt Deployment template |
| k8s/templates/deployment.star | Removed legacy ytt deployment helper/validation |
| k8s/templates/config.yml | Removed legacy ytt ConfigMap template |
| k8s/scripts/yeet.sh | Removed legacy local apply script |
| k8s/scripts/shell_in.sh | Removed legacy debug helper script |
| k8s/run-uaa-locally-with-rendered-config.sh | Removed legacy local-run helper script |
| k8s/run-minikube.sh | Removed legacy minikube deployment helper script |
| k8s/matchers/uaa_config_structs.go | Removed obsolete custom Go matcher structs |
| k8s/matchers/throw_error_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/service_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/service_account_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/secret_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/rendering_context.go | Removed obsolete ytt rendering harness |
| k8s/matchers/produce_yaml_matcher.go | Removed obsolete ytt rendering matcher |
| k8s/matchers/produce_empty_yaml_matcher.go | Removed obsolete ytt rendering matcher |
| k8s/matchers/pod_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/parse_version.go | Removed obsolete helper tied to deleted values files |
| k8s/matchers/object_meta_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/deployment_matcher.go | Removed obsolete custom Gomega matcher |
| k8s/matchers/data_value_matcher.go | Removed obsolete custom matcher |
| k8s/matchers/data_field_matcher.go | Removed obsolete custom matcher |
| k8s/matchers/container_matcher.go | Removed obsolete custom matcher |
| k8s/matchers/config_map_matcher.go | Removed obsolete custom matcher |
| k8s/image/tomcat/conf/server.xml | Removed legacy k8s image config artifact |
| k8s/go.sum | Removed Go module lockfile for deleted k8s module |
| k8s/go.mod | Removed Go module definition for deleted k8s module |
| k8s/addons/local_testing.yml | Removed legacy ytt addon values for local testing |
| k8s/addons/ingress.yml | Removed legacy ingress addon manifest |
| k8s/README.md | Removed legacy k8s/ytt-specific README |
| k8s/Makefile | Removed legacy Makefile for k8s templates/tests |
| docs/Running-on-Kubernetes.md | Added new documentation for running the published Docker image on Kubernetes |
| README.md | Replaced legacy ytt-based Kubernetes section with a link to the new docs |
| .github/workflows/codeql-analysis.yml | Removed Go from CodeQL matrix since the Go module was deleted |
| .github/dependabot.yml | Removed gomod updates for /k8s since it no longer exists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.