Skip to content

Fix unbound variable issues#3786

Open
duanemay wants to merge 2 commits intodevelopfrom
fix/unbound_var
Open

Fix unbound variable issues#3786
duanemay wants to merge 2 commits intodevelopfrom
fix/unbound_var

Conversation

@duanemay
Copy link
Member

Also, keep consistent handling of defaulting DB:-hsqldb in unit_test and integration_test scripts

Also, keep consistent handling of defaulting DB:-hsqldb in unit_test and integration_test scripts
Copilot AI review requested due to automatic review settings March 16, 2026 21:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the test/Gradle helper scripts against unbound variables and improves argument handling/quoting so wrapper scripts behave consistently across unit/integration test entrypoints.

Changes:

  • Default DB to hsqldb in scripts/unit_tests.sh to avoid unbound-variable failures under set -u.
  • Standardize argument forwarding to Gradle wrappers using "$@" (instead of "${@}" / ${*} patterns).
  • Update scripts/gradle to execute Gradle with "$@" and default to tasks when invoked with no arguments.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/unit_tests.sh Defaults DB to hsqldb when unset before booting the DB.
scripts/unit_tests Adjusts argument forwarding to "$@" for Gradle test.
scripts/integration_tests Adjusts argument forwarding to "$@" for Gradle integrationTest.
scripts/gradle Fixes Gradle invocation quoting, adds no-arg default behavior, and tweaks logging.
scripts/debug_uaa.sh Adjusts argument forwarding to "$@" for gradlew run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants