Conversation
Also, keep consistent handling of defaulting DB:-hsqldb in unit_test and integration_test scripts
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the test/Gradle helper scripts against unbound variables and improves argument handling/quoting so wrapper scripts behave consistently across unit/integration test entrypoints.
Changes:
- Default
DBtohsqldbinscripts/unit_tests.shto avoid unbound-variable failures underset -u. - Standardize argument forwarding to Gradle wrappers using
"$@"(instead of"${@}"/${*}patterns). - Update
scripts/gradleto execute Gradle with"$@"and default totaskswhen invoked with no arguments.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/unit_tests.sh | Defaults DB to hsqldb when unset before booting the DB. |
| scripts/unit_tests | Adjusts argument forwarding to "$@" for Gradle test. |
| scripts/integration_tests | Adjusts argument forwarding to "$@" for Gradle integrationTest. |
| scripts/gradle | Fixes Gradle invocation quoting, adds no-arg default behavior, and tweaks logging. |
| scripts/debug_uaa.sh | Adjusts argument forwarding to "$@" for gradlew run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, keep consistent handling of defaulting DB:-hsqldb in unit_test and integration_test scripts