Comparison of ALARA and OpenMC SS Results#13
Draft
anu1217 wants to merge 12 commits intocnerg:mainfrom
Draft
Conversation
…A_OpenMC_Comparison.py
gonuke
requested changes
Aug 2, 2024
Member
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Before reviewing the details here, I think this is a good opportunity to move all of the post-processing stuff you have in the OpenMC script to the comparison script. Rather than processing it there and saving as CSV to be imported here, just process it here from the statepoint files.
In doing so, make a function that handles the OpenMC processing and a function that handles the ALARA processing. You can then PR them one at a time, or even in smaller pieces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6