fix(agent-manager): preserve bounded tail line at exact boundary - #299
Merged
Merged
Conversation
…arts on a line boundary (#296) The bounded cold start always discarded up to the first newline of the tail window, dropping a complete line when the window started exactly on its first byte. Start discarding one byte earlier so the preceding byte decides: a newline ends the discard immediately, anything else drops the partial line as before. Costs one extra byte read per bounded scan. Remove the tailWindow() +1-byte workaround from the #279 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #296
Validation
Risk