Add CLPrompter extension integration for library list commands#3307
Open
bobcozzi wants to merge 2 commits into
Open
Add CLPrompter extension integration for library list commands#3307bobcozzi wants to merge 2 commits into
bobcozzi wants to merge 2 commits into
Conversation
… to be set to '1' The RESULT case in the switch statement was missing a break, causing fall-through into the CURRENT case. When QSYS2.QCMDEXC succeeds it returns '1', so without the break, currentLibrary was set to '1' before being overwritten by the CURRENT row from QSQLIBL(). If the setLibraryListCommand does not change *CURLIB (e.g. IMPLIBL), QSQLIBL() may not return a CURRENT row, leaving currentLibrary='1'. Also guard against overwriting config.currentLibrary with an empty string when the command result does not include a current library entry. Fixes codefori#3295
bobcozzi
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a connection profile's
setLibraryListCommandstarts with?, check if the CLPrompter extension (CozziResearch.clprompter) is installed. If it is, use CLPrompter for advanced IBM i command prompting; otherwise fall back to the existing simple input box.