Fix Mapepire NotInstalled detection when no remote jars are found#3325
Merged
sebjulliand merged 1 commit intoJun 24, 2026
Merged
Conversation
bobcozzi
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
sebjulliand
requested changes
Jun 24, 2026
sebjulliand
left a comment
sebjulliand
left a comment
Member
There was a problem hiding this comment.
It looks ok @bobcozzi , but it seems you created this branch on top of the one that exports the system version thing.
You may want to start from the main branch instead.
bobcozzi
force-pushed
the
fix/mapepire-remoteVersions-empty-check
branch
from
d6471d9 to
bf5e971
Compare
bobcozzi
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Contributor
Author
I rebased the branch onto master and pushed the updated PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Mapepire remote state detection when no remote server JARs exist.
Problem
remoteVersionsis always an array. The previous check usedif (!remoteVersions), which never evaluates to true, so the no-results case could not be classified asNotInstalled.Change
src/api/components/mapepire/index.ts, changed:if (!remoteVersions)if (remoteVersions.length === 0)Impact
NotInstalledwhen no matching remote Mapepire JARs are present.NeedsUpdateorInstalledpaths.Validation
src/api/components/mapepire/index.ts: no errors.