Use a single method to get or prompt for connection's password#3329
Merged
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Contributor
|
👋 A new build is available for this PR based on 63a8cc1. |
buzzia2001
approved these changes
Jun 25, 2026
buzzia2001
left a comment
buzzia2001
left a comment
Member
There was a problem hiding this comment.
Nice one, thank you @sebjulliand
Member
Author
|
Grazie @buzzia2001 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #3327
This PR provides a single internal method to retrieve the connection stored password or prompt and temporary store it for the duration of the connection if there's no stored password.
This avoids prompting multiple times for the password in case it's not stored or if the connection uses a private key or an SSH agent.
How to test this PR
Checklist