Change AuthnContext to use a better AUTHN_CONTEXT_UNSPECIFIED context#63
Change AuthnContext to use a better AUTHN_CONTEXT_UNSPECIFIED context#63thomasjosif wants to merge 1 commit into
Conversation
|
@thomasjosif Hmm, Im not sure simply switching out the constant is the best solution here. Most SP's expect NameID context and may require it. Maybe we can default to Name ID context and allow to change the context based on the |
upwebdesign
left a comment
upwebdesign
left a comment
There was a problem hiding this comment.
@thomasjosif this brings up some potential issues with other service providers and I think this is a great start to fixing an issue, however, simply changing the constant I don't think provides any further improvement to the existing code. Maybe we can incorporate a new environment attribute that will be read. The documentation would also need to be updated to support this change. I think you really have something going with this PR. If you have any questions regarding this review, please reach out and let me know!
|
@thomasjosif, can you make this change more accessible using a config option? That would be great! Let me know if you have the time o make that change. |
2 participants
Resolves #59 by changing the constant used to a better option as I explained in the issue.