Skip to content

Conversation

@ed3
Copy link
Contributor

@ed3 ed3 commented Dec 12, 2025

Description
Added missing files: Errors.php, Honeypot.php, Language.php
Added missing translation for: CLI.php, Core.php, HTTP.php, Publisher.php, Validation.php
For all translation files I added strict types declaration.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ed3 ed3 marked this pull request as ready for review December 12, 2025 18:12
@paulbalandan paulbalandan changed the title Update HU [hu] update missing language files Feb 9, 2026
@paulbalandan
Copy link
Member

Please fix the remaining issues:

There were 2 failures:

1) Translations\Tests\HungarianTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "hu" ('hu')
Failed asserting that the language keys "CLI.generator.className.transformer", "CLI.signals.failedSignal", "CLI.signals.noPcntlExtension", "CLI.signals.noPosixExtension", "Cast.enumInvalidCaseName", "Cast.enumInvalidType", "Cast.enumInvalidValue", "Cast.enumMissingClass", "Cast.enumNotEnum", "Email.SMTPAuthCredentials", "Email.failureSMTPAuthMethod", "Email.invalidSMTPAuthMethod", "Migrations.locked", "RESTful.cannotPaginate", "RESTful.paginateError" in the main repository are included for translation in "hu" locale.
Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:170

2) Translations\Tests\HungarianTranslationTest::testAllConfiguredLanguageKeysAreInOrder with data set "hu" ('hu')
Failed asserting that the translated language keys in "hu" locale are ordered correctly.
--- Original
+++ Translated

Images.php:
-'imageProcessFailed' => 'Image processing failed. Please verify that your server supports the chosen protocol and that the path to your image library is correct.';
+'libPathInvalid' => 'A képkönyvtárhoz tartozó elérési út hibás. Kérjük állítsa be a helyes elérési utat a beállításainál. {0}';
Failed asserting that an array is empty.

@paulbalandan paulbalandan merged commit bd4b53e into codeigniter4:develop Feb 11, 2026
11 checks passed
@paulbalandan
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants