Removed setting email_from's email in order to be compatible with AWS…#741
Removed setting email_from's email in order to be compatible with AWS…#741rajat1saxena merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67c52a83af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| : `${creator.email} <${creator.email}>`; | ||
| const from = getEmailFrom({ | ||
| name: sequence.from?.name || creator.name || creator.email, | ||
| email: process.env.EMAIL_FROM || "", |
There was a problem hiding this comment.
getEmailFrom is now called with email: process.env.EMAIL_FROM || "", so when EMAIL_FROM is not configured this builds a sender like <name> <>. I checked apps/queue/README.md and the commented queue block in deployment/docker/docker-compose.yml; neither currently requires/passes EMAIL_FROM, so deployments following those docs can enqueue sequence emails with an invalid From address and hit SMTP rejections at send time. Add a required-env check (or a safe fallback) before constructing the From header.
Useful? React with 👍 / 👎.
1 participant
In order to be compatible with AWS SES policies.