Merged
Conversation
- When person moves, moves roles with the person - Add remove button to remove a person at any position in list Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Also trying to do getElementById when possible, instead of querySelector(#id) Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Use names One, Two, Three .. to make it easy to follow Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
progval
reviewed
Oct 13, 2025
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Use codemetaGenerationEnabled to control if codemeta is to be generated or not Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com> Co-Authored-By: Val Lorentz <progval+github@progval.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a user moves an author/contributor, the roles associated with that author/contributor didn't move together with the author/contributor
This PR:
movePerson(), so when person moves, moves roles with the personauthor_listandcontributor_listare introduced, so we can guaranteed that elements in the list are all persons (the_containeris a mix of persons and control buttons) - with this we can be more precise/efficient when using selectors.movePerson()now actually move the DOM nodes, so all the nodes' children (including roles) follows automatically