Fixed NN_NAKED_NOTIFY Spotbugs Issues

[shai-almog]

No description provided.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2282 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.82% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• ❌ SpotBugs: 50 findings (Normal: 35, Low: 15) [HTML preview] [Download]
  • Top findings
    • Normal: CodenameOne/src/com/codename1/capture/Capture.java:267 – Inconsistent synchronization of com.codename1.capture.Capture$CallBack.completed; locked 66% of time (rule: IS2_INCONSISTENT_SYNC)
    • Normal: CodenameOne/src/com/codename1/charts/views/PieSegment.java:55 – Using floating-point loop counters can lead to unexpected behavior. (rule: FL_FLOATS_AS_LOOP_COUNTERS)
    • Normal: CodenameOne/src/com/codename1/charts/views/RadarChart.java:115 – Using floating-point loop counters can lead to unexpected behavior. (rule: FL_FLOATS_AS_LOOP_COUNTERS)
    • Normal: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:246 – Null passed for non-null parameter of java.util.Hashtable.put(Object, Object) in com.codename1.facebook.FacebookRESTService.keyValue(String, String) (rule: NP_NULL_PARAM_DEREF)
    • Normal: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:152 – com.codename1.impl.CodenameOneThread.getStack(Throwable) may fail to close stream (rule: OS_OPEN_STREAM)
    • …and 45 more
• ❌ PMD: 2553 findings (P2: 1, P3: 483, P4: 2069) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1039 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/RSSReader.java:500 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/Album.java:198 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1312 – Unnecessary semicolon (rule: UnnecessarySemicolon)
    • …and 2548 more
• ❌ Checkstyle: 220898 findings (Warning: 220898) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 220893 more

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 30 screenshots: 30 matched.

Native Android coverage

• 📊 Line coverage: 24.62% (2639/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.13% (12194/50528), branch 15.00% (701/4672), complexity 17.35% (736/4241), method 32.64% (594/1820), class 33.99% (103/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 24.62% (2639/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.13% (12194/50528), branch 15.00% (701/4672), complexity 17.35% (736/4241), method 32.64% (594/1820), class 33.99% (103/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 23 matched, 5 updated, 1 missing reference, 1 error.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-arc — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /Users/runner/work/_temp/cn1-ios-tests-RZeB80/graphics-draw-arc.png

  No preview available for this screenshot.
  Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 364 seconds
• Compilation Time: 111 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	38529 ms
Extract Extensions	32 ms
Google Services Setup	2 ms
Scan Classes	987 ms
Extract Libs	1979 ms
Inject Build Hints	60 ms
Generate Unit Tests	3 ms
Generate Stubs	1827 ms
Compile Stubs	3589 ms
Generate Icons	2119 ms
Prepare ParparVM	319 ms
ParparVM Execution	201449 ms
Post-VM Setup	180 ms
CocoaPods	4602 ms
Finalize	49 ms
Total Time	255727 msMaven Overhead : 109000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	87000 ms
App Install	24000 ms
App Launch	8000 ms
Test Execution	190000 ms